Re: Ange-ftp and re-search-forward -- unbelievable behavior

[Stefan Monnier]

> Being a holiday I was able to spend some time undisturbed by people
> wanting me to work.  It didn't take very long to do the binary search you
> suggested.  While it's well beyond me to tell why, the change below seems
> to be the root of it all.  After reverting this one change, my Guardian
> access seems to be working fine again.

> (defun ange-ftp-process-filter (proc str)
> ...
>        ;; handle hash mark printing
>        (and ange-ftp-process-busy
> <          (string-match "\\`#+\\'" str)
> >          (string-match "^#+$" str)
>            (setq str (ange-ftp-process-handle-hash str)))
>        (comint-output-filter proc str)
>        ;; Replace STR by the result of the comint processing.

Thanks, I've reverted this part of the patch.  It was indeed an
unsafe change.  I've reviewed the other changes and the other ones seem to
be correct.

> I can't help but think this change only sets up the conditions for some
> other bug to manifest itself.
> re-search-forward should not be able to call ange-ftp-del-tmp-name.

Agreed.  It doesn't call it directly, most likely, but somehow something
like process-filters end up being run while in the middle of
regexp matching.

> I'm obviously not terribly experienced with compiling or debugging in a
> Windows environment:-(

I consider that a quality.


        Stefan