Re: ibuffer problem with pop-up-frames non-nil

[John Paul Wallington]

"Drew Adams" <address@hidden> writes:

> emacs -q
> M-x set-variable pop-up-frames t
> M-x load-library ibuffer
> M-x ibuffer-list-buffers
>
>  ==> error "ibuffer: Wrong type argument: window-live-p, nil"

Thanks for the excellent bug report.

How about this fix:

Index: ibuffer.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/ibuffer.el,v
retrieving revision 1.73
retrieving revision 1.74
diff -u -r1.73 -r1.74
--- ibuffer.el  26 Aug 2005 10:46:50 -0000      1.73
+++ ibuffer.el  6 Nov 2005 21:06:57 -0000       1.74
@@ -2288,7 +2288,7 @@
       (save-selected-window
        ;; We switch to the buffer's window in order to be able
        ;; to modify the value of point
-       (select-window (get-buffer-window buf))
+       (select-window (get-buffer-window buf 'visible))
        (or (eq major-mode 'ibuffer-mode)
            (ibuffer-mode))
        (setq ibuffer-restore-window-config-on-quit other-window-p)