[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Warnings during compilation
From: |
Stefan Monnier |
Subject: |
Re: Warnings during compilation |
Date: |
Tue, 15 Nov 2005 23:36:25 -0500 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) |
> Does this change give good results?
> *** printing.el 24 Sep 2005 22:42:49 -0400 1.34
> --- printing.el 15 Nov 2005 15:59:42 -0500
> ***************
> *** 1042,1050 ****
> ;; To avoid compilation gripes
> ! (or (fboundp 'easy-menu-intern) ; hacked from easymenu.el
> ! (defsubst easy-menu-intern (s)
> ! (if (stringp s) (intern s) s)))
> --- 1042,1051 ----
> ;; To avoid compilation gripes
> ! (eval-and-compile
> ! (or (fboundp 'easy-menu-intern) ; hacked from easymenu.el
> ! (defsubst easy-menu-intern (s)
> ! (if (stringp s) (intern s) s))))
Wouldn't the patch below be preferable?
Stefan
--- printing.el 24 sep 2005 13:32:37 -0400 1.34
+++ printing.el 15 nov 2005 23:35:32 -0500
@@ -1027,6 +1027,7 @@
(require 'lpr)
(require 'ps-print)
+(eval-when-compile (require 'easymenu)) ;For easy-menu-intern's inlining.
(and (string< ps-print-version "6.6.4")