[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: log-view-diff

From: Juri Linkov
Subject: Re: log-view-diff
Date: Sun, 04 Dec 2005 23:45:21 +0200
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux)

>     The doc for log-view-diff says:
>       "Get the diff for several revisions.
>     If the point is the same as the mark, get the diff for this revision.
>     Otherwise, get the diff between the revisions
>     were the region starts and ends."
>     but the implementation requires that mark is active:
>       (interactive
>        (list (if mark-active (region-beginning) (point))
>            (if mark-active (region-end) (point))))
> I think they are consistent, when the former is interpreted in the
> light of our usual convention that commands that operate only
> sometimes on the region do so only if the mark is active.

I wonder what do the users of transient-mark-mode with
mark-even-if-inactive=t expect in this situation?  The variable
`mark-active' is nil in this case, but `region-beginning' or
`region-end' returns the valid mark (assuming there is an inactive mark
in the log buffer).  What is the expected behavior: to compare the
revision at point with the revision under the inactive mark, or
to compare the revision at point with its previous revision?

Juri Linkov

reply via email to

[Prev in Thread] Current Thread [Next in Thread]