emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Segmentation fault using font '7x13bold'


From: Kim F. Storm
Subject: Re: Segmentation fault using font '7x13bold'
Date: Sat, 20 May 2006 23:16:02 +0200
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)

Eli Zaretskii <address@hidden> writes:

>> Date: Sat, 20 May 2006 19:33:59 +0200
>> From: "Chris Moore" <address@hidden>
>> 
>> After quite a lot of builds I've narrowed it down to a single change.
>> 
>> This gets me sources with don't crash:
>>   cvs update -d -D '2006-05-18 00:48'
>> 
>> This gets me sources with crash:
>>   cvs update -d -D '2006-05-18 00:52'
>> 
>> The only difference between the 2 is that src/xfaces.c went from
>> version 1.346 to 1.347.

Thanks for your efforts to narrow down the cause of this.

>
> FWIW, that change (installed by Richard) has no traces in the
> ChangeLog.

The CVS log says:

revision 1.347
date: 2006-05-17 22:51:07 +0000;  author: rms;  state: Exp;  lines: +22 -23
(better_font_p): Any font beats no font.
(best_matching_font): Simplify based on above change.


Does this patch fix it???


*** xfaces.c    18 May 2006 09:33:48 +0200      1.347
--- xfaces.c    20 May 2006 23:15:03 +0200      
***************
*** 6636,6642 ****
    best = NULL;
  
    /* Find the best match among the non-scalable fonts.  */
!   for (i = 1; i < nfonts; ++i)
      if (!font_scalable_p (fonts + i)
        && better_font_p (specified, fonts + i, best, 1, avgwidth))
        {
--- 6636,6642 ----
    best = NULL;
  
    /* Find the best match among the non-scalable fonts.  */
!   for (i = 0; i < nfonts; ++i)
      if (!font_scalable_p (fonts + i)
        && better_font_p (specified, fonts + i, best, 1, avgwidth))
        {


-- 
Kim F. Storm <address@hidden> http://www.cua.dk





reply via email to

[Prev in Thread] Current Thread [Next in Thread]