RE: frame parameter menu-bar-lines changes height of frame

[Drew Adams]

See also emacs-devel thread "bug in frame-width", 2004-08-12.

The decision in that thread seems to have been to correct this bug after the
impending release - but that was two years ago! Can we perhaps fix this now,
or soon after the release? This is a regression wrt the correct behavior in
Emacs 20.


    -----Original Message-----
    From: Drew Adams [mailto:address@hidden
    Sent: Saturday, June 10, 2006 8:57 AM
    To: Emacs-Pretest-Bug
    Subject: frame parameter menu-bar-lines changes height of frame


    emacs -Q

    (make-frame '((width . 70)(height . 50)))
    (modify-frame-parameters (selected-frame) '((menu-bar-lines . 0)))
    (frame-parameters)
    (modify-frame-parameters (selected-frame) '((menu-bar-lines . 1)))
    (frame-parameters)

    Adding and removing a menu-bar line changes the visible height of the
    frame (incorrect), but it does not change the `height' frame
    parameter. The correct behavior is that observed for `tool-bar-lines':
    neither the visible frame height nor the `height' parameter is
    changed.

    I have an application that "iconifies" frames by giving them a tiny
    font size and removing the menu-bar lines, tool-bar lines, and
    vertical-scroll-bars. (This is not really iconification.)
    "Deiconifying" reinstates the original frame parameters (which were
    saved). Each time a frame is "deiconified", the height grows by one in
    Emacs 22. There is no such problem in Emacs 20.

    My guess is that this is because 1) menu-bar-lines is incorrectly
    increasing the visible frame height (without changing the `height'
    parameter), and 2) changing the font size probably (correctly)
    calculates the new visible height needed. In sum, "iconification" and
    "deiconification" are not exact inverses in Emacs 22, because of the
    menu-bar-lines mistreatment.

    Summary: menu-bar-lines should act just like tool-bar-lines wrt
    changing the frame size: the visible size should not be changed.
    Instead, one less buffer line should be shown.



    In GNU Emacs 22.0.50.1 (i386-mingw-nt5.1.2600)
     of 2006-03-20 on W2ONE
    X server distributor `Microsoft Corp.', version 5.1.2600
    configured using `configure --with-gcc (3.4) --cflags -Id:/g/include'

    Important settings:
      value of $LC_ALL: nil
      value of $LC_COLLATE: nil
      value of $LC_CTYPE: nil
      value of $LC_MESSAGES: nil
      value of $LC_MONETARY: nil
      value of $LC_NUMERIC: nil
      value of $LC_TIME: nil
      value of $LANG: ENU
      locale-coding-system: cp1252
      default-enable-multibyte-characters: t

    Major mode: Dired by name

    Minor modes in effect:
      encoded-kbd-mode: t
      tooltip-mode: t
      auto-compression-mode: t
      tool-bar-mode: t
      mouse-wheel-mode: t
      menu-bar-mode: t
      file-name-shadow-mode: t
      global-font-lock-mode: t
      font-lock-mode: t
      blink-cursor-mode: t
      unify-8859-on-encoding-mode: t
      utf-translate-cjk-mode: t
      line-number-mode: t

    Recent input:
    o <return> C-x <escape> <escape> M-p M-p M-b M-b M-f
    SPC . SPC r i g h t <return> C-x <escape> <escape>
    M-p M-p <return> C-h v f o o <return> <help-echo> <switch-frame>
    <help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
    <help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
    <switch-frame> <down-mouse-1> <mouse-1> C-x <escape>
    <escape> M-p M-p M-b M-b M-b M-b M-b M-d M-d M-d m
    i n i b u f f e r M-d <return> C-x <escape> <escape>
    M-p M-p <return> C-h v f o o <return> <help-echo> <help-echo>
    <help-echo> <switch-frame> <help-echo> <help-echo>
    <help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
    <help-echo> <help-echo> <help-echo> <menu-bar> <help-menu>
    <report-emacs-bug>

    Recent messages:
    nil [2 times]
    ((parent-id) (display . "") (visibility . t) (icon-name)
    (window-id . "3998948") (top . 0) (left . 0) (buffer-list
    #<buffer drews-lisp-20> #<buffer  *Minibuf-1*>) (unsplittable)
    (minibuffer . #<window 8 on  *Minibuf-0*>) (modeline . t)
    (width . 70) ...)
    Quit [2 times]
    nil
    ((parent-id) (display . "") (visibility . t) (icon-name)
    (window-id . "3998948") (top . 0) (left . 0) (buffer-list
    #<buffer drews-lisp-20> #<buffer  *Minibuf-1*>) (unsplittable)
    (minibuffer . #<window 8 on  *Minibuf-0*>) (modeline . t)
    (width . 70) ...)
    nil
    ((parent-id) (display . "") (visibility . t) (icon-name)
    (window-id . "3998948") (top . 0) (left . 0) (buffer-list
    #<buffer drews-lisp-20> #<buffer  *Minibuf-1*>) (unsplittable)
    (minibuffer . #<window 8 on  *Minibuf-0*>) (modeline . t)
    (width . 70) ...)
    nil
    ((parent-id) (display . "") (visibility . t) (icon-name)
    (window-id . "3998948") (top . 0) (left . 0) (buffer-list
    #<buffer drews-lisp-20> #<buffer  *Minibuf-1*>) (unsplittable)
    (modeline . t) (width . 70) (height . 53) ...)
    Loading emacsbug...done