C-down-mouse-1 and msb.el

[Marshall, Simon]

With earlier emacs releases, with emacs -q and C-down-mouse-1 would
immediately popup a buffer menu.  With M-x msb-mode and C-down-mouse-1, you
would immediately get the msb buffer menu.

Now, with CVS 2006-06-15 emacs -Q and M-x msb-mode, C-down-mouse-1 does not
popup a menu until mouse-1 is released, and then beeps with a Quit if you do
not choose an item from the menu.  (The only way to get rid of the msb menu
is to click outside it.  If you turn on debug-on-quit, then you will see a
Entering debugger... message although you will not enter the debugger.)  I
think there are 2 bugs:
(a) the msb menu should popup immediately; (b) the msb menu should not
behave as if a quit has occurred when getting rid of the menu.

It looks like this change has caused (a):

2006-05-02  Chong Yidong  <address@hidden>

        * msb.el (msb): If EVENT is a down event, read and discard the up
event.

===================================================================
RCS file: /sources/emacs/emacs/lisp/msb.el,v
retrieving revision 1.53
retrieving revision 1.54
diff -c -r1.53 -r1.54
*** msb.el      6 Feb 2006 14:33:34 -0000       1.53
--- msb.el      2 May 2006 19:27:09 -0000       1.54
***************
*** 473,478 ****
--- 473,483 ----
  See the function `mouse-select-buffer' and the variable
  `msb-menu-cond' for more information about how the menus are split."
    (interactive "e")
+   ;; If EVENT is a down-event, read and discard the
+   ;; corresponding up-event.
+   (and (eventp event)
+        (memq 'down (event-modifiers event))
+        (read-event))
    (let ((old-window (selected-window))
        (window (posn-window (event-start event))))
      (unless (framep window) (select-window window))

Commenting out that change restores the old behaviour of immediately popping
up the menu, but presumably that change was made to fix something else.  It
doesn't completely restore the old behaviour though; bug (b) is still there.

In GNU Emacs 22.0.50.1 (sparc-sun-solaris2.8, Motif Version 2.1.0)  of
2006-06-15 on perth X server distributor `Hummingbird Ltd.', version
11.0.100015 configured using `configure
'--prefix=/rvcarma/marshals/software/slash/usr/local'
'--with-x-toolkit=motif' 'CFLAGS=-g''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: en_GB.ISO8859-1
  value of $LC_CTYPE: en_GB.ISO8859-1
  value of $LC_MESSAGES: C
  value of $LC_MONETARY: en_GB.ISO8859-1
  value of $LC_NUMERIC: en_GB.ISO8859-1
  value of $LC_TIME: en_GB.ISO8859-1
  value of $LANG: en_GB.ISO8859-1
  locale-coding-system: iso-8859-1
  default-enable-multibyte-characters: t

Major mode: Emacs-Lisp

Minor modes in effect:
  delete-selection-mode: t
  mouse-sel-mode: t
  msb-mode: t
  partial-completion-mode: t
  show-paren-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t