Re: 4 week-old pretest bugs

[Chris Moore]

Jan Djärv <address@hidden> writes:

> It is probably very timing related.  A small change changes the timing.  Can 
> you try the attachet patch?

That fixes the problem.

I ran the patched program 4 times, each time clicking the first icon a
lot of times to see if I could provoke a crash and I couldn't.

The first time I clicked the icon in the first run, however, I saw a
CRITICAL message in the terminal I ran it from:

    address@hidden:~/programs/emacs$ emacs -Q

    (emacs:16263): libgnomevfs-CRITICAL **: gnome_vfs_get_uri_from_local_path: 
assertion `g_path_is_absolute (local_full_path)' failed
    address@hidden:~/programs/emacs$ emacs -Q
    address@hidden:~/programs/emacs$ emacs -Q
    address@hidden:~/programs/emacs$ emacs -Q
    address@hidden:~/programs/emacs$ 

This may of course be completely irrelevant.

Chris.


> Index: alloc.c
> *** alloc.c.~1.405.~  2007-01-01 19:19:05.000000000 +0100
> --- alloc.c   2007-01-11 08:44:47.000000000 +0100
> ***************
> *** 130,137 ****
>   #define BLOCK_INPUT_ALLOC                       \
>     do                                            \
>       {                                           \
> !       if (pthread_self () == main_thread)   \
> !     BLOCK_INPUT;                            \
>         pthread_mutex_lock (&alloc_mutex);    \
>       }                                           \
>     while (0)
> --- 130,137 ----
>   #define BLOCK_INPUT_ALLOC                               \
>     do                                                    \
>       {                                                   \
> !       if (pthread_equal (pthread_self (), main_thread)) \
> !         sigblock (sigmask (SIGIO));                     \
>         pthread_mutex_lock (&alloc_mutex);                \
>       }                                                   \
>     while (0)
> ***************
> *** 139,146 ****
>     do                                            \
>       {                                           \
>         pthread_mutex_unlock (&alloc_mutex);  \
> !       if (pthread_self () == main_thread)   \
> !     UNBLOCK_INPUT;                          \
>       }                                           \
>     while (0)
>   
> --- 139,146 ----
>     do                                                    \
>       {                                                   \
>         pthread_mutex_unlock (&alloc_mutex);              \
> !       if (pthread_equal (pthread_self (), main_thread)) \
> !         sigunblock (sigmask (SIGIO));                   \
>       }                                                   \
>     while (0)
>