The highlight of "common prefix" in completion buffer is broken.

[Kim F. Storm]

Try this:

cd emacs/src
/emacs -Q
C-x C-f TAB TAB

shows a completion buffer with completely arbitrary highlighting of
different chars in some file names.

It seems like it is mistakenly taking the whole file name rather
than only the non-directory part when choosing what to highlight.
This is because minibuffer-completing-file-name is nil!

FWIW, C-x C-b TAB does the right thing.

Reverting the following change fixes the bug:

2007-01-30  Richard Stallman  <address@hidden>

        * minibuf.c (read_minibuf):
        Save and clear Vminibuffer_completing_file_name.
        (read_minibuf_unwind): Restore it.
        (Vminibuffer_completion_table, Qminibuffer_completion_table)
        (Vminibuffer_completion_predicate, Qminibuffer_completion_predicate)
        (Vminibuffer_completion_confirm, Qminibuffer_completion_confirm)
        (Vminibuffer_completing_file_name): Definitions moved up.


Yes I know that this change was made to fix some other bug,
but the number of things broken by that change is increasing,
so that change doesn't seem like the right fix!!



In GNU Emacs 22.0.93.1 (i686-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2007-02-05 on kfs-l.imdomain.dk
X server distributor `The XFree86 Project, Inc', version 11.0.40300000
configured using `configure  'CFLAGS=-O0 -g''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8
  default-enable-multibyte-characters: t

Major mode: CVS

Minor modes in effect:
  shell-dirtrack-mode: t
  display-time-mode: t
  cua-mode: t
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-r <up> C-s C-s C-s <down> <down> <C-left> <C-left> 
C-s C-w C-w C-w C-r C-r C-r C-s C-s C-s C-s C-s C-s 
C-s C-x C-f C-f <tab> <tab> C-g C-x v g <next> <next> 
<next> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> M-x c c <return> C-g C-u M-x c c <return> y y 
y <help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <menu-bar> <help-menu> <report-emacs-b
ug>

Recent messages:
Annotating...
Redisplaying annotation...done (Spanned from 5527.7 to 1.7 days old)
Annotating... done
Quit
Wrote /home/kfs/fsf/latest/src/x.el
Running cvs update ...
CVS process has completed in *cvs*
Saving file /home/kfs/emacs/common/emacs/user/kfs/.newsrcmail-dribble...
Wrote /home/kfs/emacs/common/emacs/user/kfs/.newsrcmail-dribble
Loading emacsbug...done


--
Kim F. Storm <address@hidden> http://www.cua.dk