[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: CC Mode, labels not fontified
From: |
Alan Mackenzie |
Subject: |
Re: CC Mode, labels not fontified |
Date: |
30 Mar 2007 23:04:24 +0200 |
Date: |
Fri, 30 Mar 2007 23:22:56 +0100 |
User-agent: |
Mutt/1.5.9i |
Hi, Simon, Stefan and Chong!
I'll take a look at this bug over the weekend.
Two observations:
(i) the "+2956" argument isn't essential to the bug - M-g M-g 2956 works
just as well.
(ii) With Emacs 21.3, and CC Mode 5.31.4 (i.e. "equivalent" CC Mode),
"emacs -q --no-site-file -f global-font-lock-mode +2956 \
emacs/emacs/src/eval.c" fontifies the label correctly.
--
Alan.
On Fri, Mar 30, 2007 at 10:17:54AM +0100, Marshall, Simon wrote:
> To give context, the change was to stop this overwriting-mis-fontification:
>
> case foo:
> ^^^ not fontified (generally used to be fontified as a
> label/constant)
> ^^^^ fontified as a label/constant (used to be fontified as a keyword)
>
> With the change, "case" remains fontified as a keyword.
>
> Superficially, it would seem my change would prevent goto labels from being
> fontified. That might be true, given my lack of understanding of the new
> cc-mode fontification engine. However, it looks like it might be some
> interaction with jit-lock mode, since if font-lock-support-mode is nil, then
> fontification is OK. (This is presumably why M-o M-o also fontifies
> correctly.)
>
> So I'm tempted to say it's not (simply) due to my change. Stefan, Alan, any
> pointers?
>
> Simon.
>
> > -----Original Message-----
> > From: Chong Yidong [mailto:address@hidden On Behalf Of Chong Yidong
> > Sent: 30 March 2007 04:23
> > To: Simon Marshall; Feng Li
> > Cc: address@hidden
> > Subject: Re: CC Mode, labels not fontified
> >
> > address@hidden (Johan Bockgård) writes:
> >
> > > $ emacs -Q +2956 .../emacs/src/eval.c
> > >
> > > The `retry:' label is not highlighted. It is fontified correctly by
> > > `M-o M-o' though.
> >
> > Simon, this appears to be the result of your change. Could
> > you try to fix your patch?
> >
> > 2006-11-10 Simon Marshall <address@hidden>
> >
> > * progmodes/cc-fonts.el (c-font-lock-declarations): Don't overwrite
> > fontification for "case" and "default" keywords.
> >
> > *** emacs/lisp/progmodes/cc-fonts.el 2006/07/10 13:17:09 1.16
> > --- emacs/lisp/progmodes/cc-fonts.el 2006/11/10 16:58:27 1.17
>
>
> This email message is intended for the named recipient only. It may be
> privileged and/or confidential. If you are not the named recipient of this
> email please notify us immediately and do not copy it or use it for any
> purpose, nor disclose its contents to any other person. Misys Banking
> Systems is a trading name of Misys International Banking Systems Limited
> which is registered in England and Wales under company registration number
> 00971479 and with its registered office address at Burleigh House, Chapel
> Oak, Salford Priors, Evesham WR11 8SP. THIS E-MAIL DOES NOT CONSTITUTE THE
> COMMENCEMENT OF LEGAL RELATIONS BETWEEN YOU AND MISYS INTERNATIONAL BANKING
> SYSTEMS LIMITED. PLEASE REFER TO THE EXECUTED CONTRACT BETWEEN YOU AND THE
> RELEVANT MEMBER OF THE MISYS GROUP FOR THE IDENTITY OF THE CONTRACTING PARTY
> WITH WHICH YOU ARE DEALING.