emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: patch for locate.el when called with prefix arg


From: Luc Teirlinck
Subject: Re: patch for locate.el when called with prefix arg
Date: Tue, 24 Apr 2007 18:59:30 -0500 (CDT)

       So I do not believe that there is any need to test the patch for
       `locate-in-alternate-database' which I proposed.  I believe that it is
       better to just forget about that patch.

   Ok, let's consider this issue done.

I checked that `locate-prompt-for-command' does indeed not work
properly if `locate-prompt-for-command' is set to t.  It would
similarly not work correctly if the numeric arg were passed through to
`locate'.  So my patch for `locate-prompt-for-command' definitely made
no sense.

Since, as I explained, the functionality is useless if
`locate-prompt-for-command' is t, this is not a bug to be fixed.  But
maybe it might be good to point this out in the docstring.  The
following patch does this.  This is purely a doc fix, so maybe this
could still be committed in both the release and development branches:

===File ~/locate-diff=======================================
*** locate.el   23 Apr 2007 18:54:38 -0500      1.44
--- locate.el   24 Apr 2007 18:44:09 -0500      
***************
*** 669,675 ****
  
  ;; Only for GNU locate
  (defun locate-in-alternate-database  (search-string database)
!   "Run the GNU locate command, using an alternate database."
    (interactive
        (list
         (progn
--- 669,680 ----
  
  ;; Only for GNU locate
  (defun locate-in-alternate-database  (search-string database)
!   "Run the GNU locate command, using an alternate database.
! 
! This function only works if you use GNU locate.  It does not work
! properly if `locate-prompt-for-command' is set to t.  In that
! case, you can just run the regular `locate' command and specify
! the database on the command line."
    (interactive
        (list
         (progn
============================================================




reply via email to

[Prev in Thread] Current Thread [Next in Thread]