Re: dabbrev--eliminate-newlines

[Johan Bockgård]

Richard Stallman <address@hidden> writes:

> Does this patch fix it?

There are still problems (but none that should delay the release! :).

In dabbrev--substitute-expansion `(search-backward old)' might find
the wrong place after the whichspace has been converted.

Consider a buffer containing the text

"1  2   3 "

(that is 1 SPC SPC 2 SPC SPC SPC 3 SPC)

Then at the end of the buffer, type 1 SPC SPC M-/ SPC M-/.

The buffer now contains

"1  2   3 1  2  3"  (with the patch there is one space less before the 3)

Press M-/ again:

"1  2 2 1  2  3"
       ^
      point

Here OLD is "   3", and so `search-backward' moves too far.


BTW, I wonder what kind of situation "Start searching at end of ABBREV
so that any whitespace carried over from the existing text is not
changed" refers to.

-- 
Johan Bockgård