[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[emms-help] [PATCH] BUG: Playing empty directory tree

From: Daniel Brockman
Subject: [emms-help] [PATCH] BUG: Playing empty directory tree
Date: Fri, 01 Oct 2004 15:21:32 +0200
User-agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux)

Hi Emacs rockers,

If you run `emms-play-directory' and select a directory with no music
in it, you get an obscure error.  I'm attaching a very simple fix.

Note the removal of the final period in the error message, as per the
documentation of `error':

    ``In Emacs, the convention is that error messages start with a
    capital letter but *do not* end with a period.  Please follow this
    convention for the sake of consistency.''

Oh, and you get another minor fix for free.

Thanks for a great player --- keep up the good work!


Daniel Brockman

cvs diff: Diffing .
Index: emms.el
RCS file: /cvsroot/emms/emms/emms.el,v
retrieving revision 1.32
diff -u -r1.32 emms.el
--- emms.el     20 Sep 2004 13:08:59 -0000      1.32
+++ emms.el     1 Oct 2004 13:07:37 -0000
@@ -480,7 +480,7 @@
   "Play the tracks in LIS."
   (let ((new (vconcat lis)))
     (when (zerop (length new))
-      (error "No tracks found." source))
+      (error "No tracks found"))
     (emms-playlist-set-playlist new)
     (emms-playlist-set-current 0)
Index: emms-source-file.el
RCS file: /cvsroot/emms/emms/emms-source-file.el,v
retrieving revision 1.22
diff -u -r1.22 emms-source-file.el
--- emms-source-file.el 17 Sep 2004 19:35:39 -0000      1.22
+++ emms-source-file.el 1 Oct 2004 13:07:36 -0000
@@ -107,7 +107,7 @@
   "An EMMS source for multiple directory trees - either DIR, or the
 value of `emms-source-file-default-directory'."
   (interactive (list
-                (read-file-name "Play directory: "
+                (read-file-name "Play directory tree: "

reply via email to

[Prev in Thread] Current Thread [Next in Thread]