[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[emms-help] I don't like the name `emms-sort-on-file-add'

From: Daniel Brockman
Subject: [emms-help] I don't like the name `emms-sort-on-file-add'
Date: Thu, 16 Jun 2005 02:05:38 +0200
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)

I think the name `emms-sort-on-file-add' suggests that the whole
playlist will be sorted each time a file is added.  I might actually
have suggested that name, I don't remember, but I want to change it.

So how about `emms-playlist-sort-added-tracks-p'?

--- emms.el     15 Jun 2005 16:54:17 +0200      1.46
+++ emms.el     15 Jun 2005 22:57:55 +0200      
@@ -166,11 +166,14 @@
   "The zero-based playlist index of the current EMMS track.
 If there is no playlist, this will be set to nil.")
-(defcustom emms-sort-on-file-add nil
+(defcustom emms-playlist-sort-added-tracks-p nil
   "*If non-nil, sort tracks before adding them to the EMMS playlist."
   :group 'emms
   :type 'boolean)
+(define-obsolete-variable-alias 'emms-sort-on-file-add
+  'emms-playlist-sort-added-tracks-p)
 ;;; User Interface
@@ -423,7 +426,7 @@
   (let ((idx (or idx (length emms-playlist))))
      (vconcat (substring emms-playlist 0 idx)
-              (if emms-sort-on-file-add
+              (if emms-playlist-sort-added-tracks-p
                   (emms-playlist-sort-vector seq)
               (substring emms-playlist idx)))))
@@ -541,7 +544,7 @@
 (defun emms-source-play (lis)
   "Play the tracks in LIS, after first clearing the EMMS playlist."
   (let ((new 
-         (if emms-sort-on-file-add
+         (if emms-playlist-sort-added-tracks-p
              (emms-playlist-sort-vector (vconcat lis))
            (vconcat lis))))
     (when (zerop (length new))
Daniel Brockman <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]