[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [emms-help] Re: substr doesn't work on sequences (in XEmacs)
From: |
Jorgen Schaefer |
Subject: |
Re: [emms-help] Re: substr doesn't work on sequences (in XEmacs) |
Date: |
Mon, 29 Aug 2005 04:09:37 +0200 |
User-agent: |
Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) |
Michael Olson <address@hidden> writes:
> Any objections to the installation of the following patch?
Yes.
> --- orig/emms.el 2005-08-28 19:38:04.000000000 -0500
> +++ mod/emms.el 2005-08-28 19:37:52.000000000 -0500
> @@ -41,6 +41,8 @@
> (defvar emms-version "1.3 $Revision: 1.63 $"
> "EMMS version string.")
>
> +(eval-when-compile (require 'cl))
I do have an objection to requiring `cl' when there is a perfectly
working variant outside of `cl' available.
The correct solution is something along the lines of
(defalias emms-subseq (if (featurep 'xemacs)
'subseq
'substring)
"...")
I would have commited that already, but I currently lack the time
to test it.
> Using subseq also fixes a problem I was seeing when
> emms-playlist is nil upon calling emms-playlist-add.
Could you elaborate?
Greetings,
-- Jorgen
--
((email . "address@hidden") (www . "http://www.forcix.cx/")
(gpg . "1024D/028AF63C") (irc . "nick forcer on IRCnet"))
pgpBqfbHK_bPk.pgp
Description: PGP signature