[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[emms-help] Re: [Emms-patches] darcs patch: emms-url: Improve emms-url-q

From: William Xu
Subject: [emms-help] Re: [Emms-patches] darcs patch: emms-url: Improve emms-url-quote.
Date: Fri, 15 Feb 2008 13:07:39 +0900
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (darwin)

Michael Olson <address@hidden> writes:

> Thu Feb 14 20:58:00 CST 2008  Michael Olson <address@hidden>
>   * emms-url: Improve emms-url-quote.
>    - Don't clobber the match data.
>    - Don't escape the colon in "http://";.

For escaping the colon in "http://";, the patch uses: 

    (string-match "\\`\\([^:]+:\\)\\(.+\\)\\'" s)
    (let ((handler (match-string 1 s))
          (loc (or (match-string 2 s) s))

Do you assume that argument must be a full uri path like `http://foo' ?
And how to handle cases like 'http://foo@:bar'?

I thought the argument could be any string, so that this function would
be generally useful. For creating a full uri path, i would rather use
something like: 

    (concat "http://"; (emms-url-quote "blahblah"))


reply via email to

[Prev in Thread] Current Thread [Next in Thread]