[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[emms-help] [PATCH] emms-lastfm-client.el: Fix warnings

From: Tim Landscheidt
Subject: [emms-help] [PATCH] emms-lastfm-client.el: Fix warnings
Date: Mon, 07 Jun 2010 11:44:30 +0000
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)


the attached patch fixes some warnings in

  emms-lastfm-client-radio-tune-ok referenced a free vari-
able emms-lastfm-client-tuned-station-alist which is nowhere
used in EMMS. So another way to deal with it would be of
course to define the variable properly. As I don't use
Last.fm I can't assess the possible options.

diff --git a/lisp/emms-lastfm-client.el b/lisp/emms-lastfm-client.el
index fb3f69f..1e975d9 100644
--- a/lisp/emms-lastfm-client.el
+++ b/lisp/emms-lastfm-client.el
@@ -31,6 +31,7 @@
 ;;; Code:
 (require 'md5)
+(require 'parse-time)
 (require 'xml)
 (defvar emms-lastfm-client-api-key nil
@@ -592,8 +593,7 @@ This function includes the cryptographic signature."
     (cond (session-key
           (setq emms-lastfm-client-api-session-key
-          (message "Emms Last.fm session key retrieval successful"
-                   session-key))
+          (message "Emms Last.fm session key retrieval successful"))
          (t (error "failed to parse session key data %s" data)))))
 (defun emms-lastfm-client-auth-get-session-failed (data)
@@ -645,8 +645,7 @@ This function includes the cryptographic signature."
                                 (caddr (car response)))))
       (setq response (cdr response)))
     (when (not data)
-      (error "could not parse station information %s" data))
-    (setq emms-lastfm-client-tuned-station-alist data)))
+      (error "could not parse station information %s" data))))
 ;;; ------------------------------------------------------------------
 ;;; method: radio.getPlaylist [http://www.last.fm/api/show?service=256]

reply via email to

[Prev in Thread] Current Thread [Next in Thread]