Re: [emms-help] 4.2 release tasks: emms-print-metadata install

[Yoni Rabkin]

Alex Kost <address@hidden> writes:

> Yoni Rabkin (2016-10-30 09:27 -0400) wrote:
>
>> Alex Kost <address@hidden> writes:
>>
>>> Yoni Rabkin (2016-10-24 21:42 -0400) wrote:
>>>
>>>> In 4.2 I want emms-print-metadata to be installed by `make install',
>>>> just like the manual says it is.
>>>>
>>>> As far as I can tell emms-print-metadata isn't being installed into
>>>> /usr/bin/ by `make install'. Can people confirm this?
>>>
>>> I confirm, also 'make' doesn't build emms-print-metadata, because it is
>>> not specified in "all" target.
>>
>> Thank you for this.
>>
>> I've fixed this and it will be released along with version 4.2 in
>> November.
>
> I see that you didn't add 'emms-print-metadata' to 'all' target in
> commit cbbe098¹, so "make" still doesn't build it.  Was it intentional?

Yes. At this point we still want to keep the make phase to be about
elisp. This should be resolved when we decide how to do the compilation
in way compatible with remotely installable elisp packages.

> Also you use:
>
>   install -m 755 $(SRCDIR)/emms-print-metadata $(BINDIR)/emms-print-metadata;
>
> This will fail if BINDIR does not exist (this is the case for such
> systems as GuixSD or NixOS).  Could you please also add "-D" flag to
> "install" command?

Do you have access to those systems? Can you do a test to see that it
would work as intended and send a patch?

-- 
   "Cut your own wood and it will warm you twice"