Re: [emms-help] Dynamic cover thumbnail caching

[Pierre Neidhardt]

I forgot to report an issue I have with the current cover code:

To hook my caching code into the current process, I have to set
`emms-cache-covers':

        (setq emms-browser-covers (function emms-cache-covers))


The above won't work because `emms-browser--build-cover-filename'
expects a list:


        (defun emms-browser--build-cover-filename ()
          "Build `emms-browser--covers-filename'.
        
        Based on from `emms-browser-covers' and
        `emms-browser-covers-file-extensions'."
          (setq emms-browser--covers-filename
                (mapcar (lambda (cover)
                          (if (file-name-extension cover)
                              (list cover)
                            (mapcar (lambda (ext) (concat cover "." ext))
                                    emms-browser-covers-file-extensions)))
                        emms-browser-covers)))

One possible patch: Store the function with fset and modify
`emms-browser-get-cover-from-path' accordingly:

        (fset 'emms-browser-covers 'emms-cache-covers)

        (defun emms-browser-get-cover-from-path (path &optional size)
        ...
        -         ((functionp emms-browser-covers)
        -          (funcall emms-browser-covers (file-name-directory path) 
size))
        +         ((functionp 'emms-browser-covers)
        +          (emms-browser-covers (file-name-directory path) size))

-- 
Pierre Neidhardt

The wages of sin are unreported.