[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[emms-help] More mpv player code review

From: Pierre Neidhardt
Subject: [emms-help] More mpv player code review
Date: Wed, 06 Jun 2018 13:55:45 +0200
User-agent: mu4e 1.0; emacs 26.1

Sorry for the long delay, I've finally spent some time review the mpv
It's pretty neat I think, I like it.
I've fixed a few nits already.

Some questions:

- In `emms-player-mpv-proc-stop': (setq emms-player-mpv-proc nil) should
  be done at the end I think, or in case of interrupt ("C-g") at the
  wrong time the variable will be nil while the player will not be
  stopped.  Further calls to emms-player-mpv-proc-stop won't be able to
  stop the player.

- In `emms-player-mpv-ipc-connect-fifo':

--8<---------------cut here---------------start------------->8---
(format "cat > '%s'"
 (replace-regexp-in-string "'" "'\"'\"'" emms-player-mpv-ipc-socket t t))
--8<---------------cut here---------------end--------------->8---

That looks like proper ugly shell! :p I haven't tried, but couldn't we
use `shell-quote-argument' instead?

--8<---------------cut here---------------start------------->8---
(concat "cat > "
 (shell-quote-argument emms-player-mpv-ipc-socket))
--8<---------------cut here---------------end--------------->8---

Thank you very much for your hard work, Mike!

Pierre Neidhardt

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]