Re: [PATCH] Add: tracktag interface and support for Opus

[Grant Shoshin Shangreaux]

Yoni Rabkin writes:

> The emms-tracktag should be changed to emms-info-tracktag in order to be
> consistent with the rest of the info methods.

the tracktag tool is specifically for writing tags. there's a separate
utility for reading info, but i hadn't planned on integrating that at
this time. audiotools does look fairly handy, so if there were desire to
enhance EMMS's features with some of its utilities, that is something I
could certainly work on. For now, I really just wanted an Opus capable
tagger. Its unfortunate there didn't seem to be a good stand alone
option for it (opustools unfortunately doesn't include a tagger, unless
you want to re-encode the file).

that being said, there's not much to the integration at this point, it
could be brought into the emms-tag-editor module, rather than being on
its own.

> I think that adding ert testing is fine, but I would only add it after
> the code has stabilized somewhat. Since the unit tests are very short,
> they can be kept in the same file as the tracktag code for now.

sounds good. i've been trained to write tests at work all the time, so
its more of a development habit of mine. i do think it makes sense wait
until this code/feature has stabilized.

>> By the way, I used some real metadata from tracks I have, but afaik that
>> is not copyrighted data. If we'd prefer to keep it out of the code base,
>> I can replace it.
>
> Indeed, we should not have real metadata in the codebase since this is
> what an automated search 'bot would latch onto and potentially cause
> trouble.

i just remove the tests from the commit at this point.

> Based on the volume of code you are adding, I would recommend that you
> open a Savannah account (if you don't have one already) and that I give
> you write access to the repo. At that point you can do all of your work
> in a remote branch.
>
> In a remote branch you can break anything and everything with impunity,
> and everyone else can easily grab a copy for testing. We recently did
> this with Petteri's info-native branch and it worked well.

done! thank you!