[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: pvm.jitter patch for no-threading

From: Luca Saiu
Subject: Re: pvm.jitter patch for no-threading
Date: Sat, 03 Apr 2021 21:34:03 +0200
User-agent: Gnus (Gnus v5.13), GNU Emacs 27.0.50, x86_64-pc-linux-gnu

On 2021-04-03 at 20:12 +0200, Jose E. Marchesi wrote:

> Can you please add that info to some suitable section in HACKING, as
> part of the patch series?


>>> Also, there are a few commented-out:
>>> # non-relocatable
>>> Do we need these?
>> Not really, but I would suggest them.  In an ideal world where every
>> other case had already been optimised, I would make I/O instructions
>> non-relocatable just in order to improve code locality.
>> In the current Poke this does not matter much because of PVM_RAISE_*,
>> which occurs in *a lot* of places, and makes the code very large -- it
>> also causes some defects, but now as you can see defects do not affect
>> correctness.
> Ok, but then please use something like:
> # XXX make non-relocatable
> so we can find it easily.  We use XXX for that purpose in the codebase
> :)

Okay, done.

> It would be even better if you could add suitable todo entries to
> etc/poke.rec ;)

Done that as well.

> Allright, the patch is OK for master.

Thank you.  Pushed.

Luca Saiu
* My personal web site:  http://ageinghacker.net
* Jitter:                http://ageinghacker.net/projects/jitter
* GNU epsilon:           http://www.gnu.org/software/epsilon

I support everyone's freedom of mocking any opinion or belief, no
matter how deeply held, with open disrespect and the same unrelented
enthusiasm of a toddler who has just learned the word "poo".

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]