erc-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Erc-discuss] erc-cmd-LIST always sends an option


From: Sascha Wilde
Subject: [Erc-discuss] erc-cmd-LIST always sends an option
Date: Tue, 15 May 2012 18:15:28 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux)

Hi *,

erc-cmd-LIST always sends LIST with an option.  If the user did not
specify an option an empty option is send.  To my understanding this is
standard conferment (though ugly).  But at least one widely used ircd
get confused by this behavior, see:
https://github.com/inspircd/inspircd/issues/120

So I propose the following patch:

--- erc-list.el Mon May 14 22:39:14 2012 +0200
+++ erc-list.el Tue May 15 18:10:26 2012 +0200
@@ -209,8 +209,10 @@
      321
      (list 'progn
         (list 'erc-list-install-322-handler (current-buffer)))))
-  (erc-server-send (concat "LIST :" (or (and line (substring line 1))
-                                    ""))))
+  (erc-server-send (concat "LIST" (or (and line 
+                                         (> (length (substring line 1)) 0)
+                                          (concat " :" (substring line 1)))
+                                     ""))))
 (put 'erc-cmd-LIST 'do-not-parse-args t)


This is erc v5.3 from GNU Emacs HEAD.

cheers
sascha
-- 
Sascha Wilde 
Hi! I'm a .signature *virus*! Copy me into your ~/.signature to help me spread!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]