[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Findutils-patches] [PATCH] Include sys/stat.h in files where we use

From: James Youngman
Subject: Re: [Findutils-patches] [PATCH] Include sys/stat.h in files where we use struct stat.
Date: Tue, 26 Jun 2007 16:20:23 +0100

On 6/26/07, Eric Blake <address@hidden> wrote:
Reasonable enough to keep the inner parenthesis when they are
user-visible.  However, there's still the question of whether
 assert ( (cond1) || (cond2) );
 assert ((cond1) || (cond2));

looks nicer, but a quick check shows that, for gcc 3.4.4 at least, the
leading and trailing space of the former are not stringized.

Ack, I'll remove the superfluous spaces RSN.

You provide a nice argument.  Maybe it's worth documenting that in the
findutils maintainers note, since the GNU Coding Standards are silent on
preference between 0 and '\0'.

Yes, I will do this.   There is probably room for guidance around how
to add predicates, test user input, handling ENOENT and so forth too.

As in the following?  Yes, I think this is safer:

union {
  pred_cost_lookup* fn;
  char mem[sizeof (pred_cost_lookup*)];
} u1, u2;
u1.fn = p1;
u2.fn = p2;
return memcmp (u1.mem, u2.mem, sizeof (pred_cost_lookup*));

OK, I'll prepare a patch which does that.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]