findutils-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Findutils-patches] [PATCH 14/19] Avoid sc_prohibit_stat_st_blocks check


From: James Youngman
Subject: [Findutils-patches] [PATCH 14/19] Avoid sc_prohibit_stat_st_blocks check, since it is broken.
Date: Fri, 2 Apr 2010 23:47:14 +0100

* cfg.mk (skip_broken_checks): Skip sc_prohibit_stat_st_blocks.

Signed-off-by: James Youngman <address@hidden>
---
 ChangeLog |    5 +++++
 cfg.mk    |    6 +++---
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 48b7e14..58329a9 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,7 +1,12 @@
 2010-04-02  James Youngman  <address@hidden>
 
+       Avoid sc_prohibit_stat_st_blocks check, since it is broken.
+       * cfg.mk (skip_broken_checks): Skip sc_prohibit_stat_st_blocks.
+
        Enable syntax checker sc_the_the, detecting doubled 'the'.
        * cfg.mk (false_positives): Enable syntax checker sc_the_the
+       (skip_broken_checks): Skip sc_prohibit_stat_st_blocks
+
        * build-aux/src-sniff.py (checkers): Avoid false positive with
        sc_the_the.
 
diff --git a/cfg.mk b/cfg.mk
index 47f49e0..ef981d5 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -23,8 +23,7 @@ skip_dunno = sc_immutable_NEWS sc_makefile_at_at_check \
        sc_prohibit_quote_without_use sc_prohibit_quotearg_without_use
 
 # Understand, but fix later.
-skip_defer = sc_program_name \
-       sc_prohibit_magic_number_exit sc_prohibit_stat_st_blocks
+skip_defer = sc_program_name sc_prohibit_magic_number_exit
 
 # False positives I don't have a workaround for yet.
 # sc_space_tab: several .xo test output files contain this sequence
@@ -48,7 +47,8 @@ skip_blocked_notours = \
 
 # sc_prohibit_strcmp is broken because it gives false positives for cases
 # where neither argument is a string literal.
-skip_broken_checks = sc_prohibit_strcmp
+# sc_prohibit_stat_st_blocks produces a false positive on definition of 
ST_NBLOCKS.
+skip_broken_checks = sc_prohibit_strcmp sc_prohibit_stat_st_blocks
 
 local-checks-to-skip = \
        $(skip_too_picky) $(skip_dunno) $(false_positives) $(skip_defer) \
-- 
1.7.0





reply via email to

[Prev in Thread] Current Thread [Next in Thread]