[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Findutils-patches] [PATCH] Don't return int to represent a boolean

From: James Youngman
Subject: Re: [Findutils-patches] [PATCH] Don't return int to represent a boolean value.
Date: Mon, 5 Apr 2010 20:53:17 +0100

On Mon, Apr 5, 2010 at 2:31 PM, Eric Blake <address@hidden> wrote:
> On 04/04/2010 04:43 PM, James Youngman wrote:
>> * find/defs.h: fd_leak_check_is_enabled should return boolean, not
>> int.  Likewise following_links and digest_mode.
>> +++ b/find/defs.h
>> @@ -495,7 +495,7 @@ struct predicate *get_new_pred_chk_op PARAMS((const 
>> struct parser_table *entry,
>>  float  calculate_derived_rates PARAMS((struct predicate *p));
>>  /* util.c */
>> -int fd_leak_check_is_enabled (void);
>> +boolean fd_leak_check_is_enabled (void);
> In C99, it is spelled bool, not boolean (that is from Java).  I'm not
> sure where you are defining boolean, but it would be nicer to use bool
> throughout.

Thanks for the feedback.   I entirely agree, so I pushed the attached
additional patch.


Attachment: 0002-Use-bool-instead-of-the-previous-typedef-boolean.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]