[Findutils-patches] Re: [PATCH 2/4] Exec predicates now store which directory they want to run in.

[James Youngman]

On Mon, Apr 12, 2010 at 5:06 PM, Eric Blake <address@hidden> wrote:
> On 04/10/2010 02:33 PM, James Youngman wrote:
>> (starting_dir): Remove devlaration of global variable.
>> (starting_desc): Remove devlaration of global variable.
>
> s/devlaration/declaration/g
Thanks, fixed.


> If you are already in an atexit handler, then you need to force non-zero
> exit status.  It would be worth adding _exit(exit_failure) after that
> error() call (see gnulib's closeout.c for an example).

Done.

>> +       err = (*callback)(usercontext);
>
> These days, it's both portable and less typing to write:
>
> err = callback (usercontext);

Done.

James.