[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [fluid-dev] chorus effect range

From: David Henningsson
Subject: Re: [fluid-dev] chorus effect range
Date: Wed, 06 Apr 2011 19:54:00 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20110307 Thunderbird/3.1.9

On 2011-04-05 22:10, Sven Meier wrote:
Hi all,

in fluid_synth.c the documentation for fluid_synth_set_chorus() states
the following:

* @param level Chorus level (0.0-1.0)

However in synth.h I find the following:

#define FLUID_CHORUS_DEFAULT_LEVEL 2.0f /**< Default chorus level */

Which one is wrong?

Here's what I found in the code:

 else if (chorus->level > 10) {
fluid_log(FLUID_WARN, "chorus: level must be < 10. A reasonable level is << 1! "
             "Setting it to 0.1.");

So now we have three versions...since 2.0f is actually used and nobody has complained it sounds unreasonable, my suggestion is that we change change the range to 0 - 10.0f wherever it says something else. Comments?

// David

reply via email to

[Prev in Thread] Current Thread [Next in Thread]