[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [fluid-dev] [PATCH] sampledata caching

From: Kjetil Matheussen
Subject: Re: [fluid-dev] [PATCH] sampledata caching
Date: Fri, 12 Oct 2012 11:01:38 +0200
User-agent: Roundcube Webmail/0.6

On 12.10.2012 10:54, David Henningsson wrote:
On 10/10/2012 10:29 AM, Kjetil Matheussen wrote:
On 10.10.2012 09:51, Kjetil Matheussen wrote:
Another thing we need to verify is that the sampledata is read-only once it's been bigendian converted. If it is not, chances are that two
threads would both modify the sampledata, causing problems.

Okay. I'll see if there's any trouble changing the sampledata field
from short* to const short*.

There was no problems setting _fluid_sample_t->data and
to const short*.

The only warning I got which made me somewhat worried was in
fluid_ramsfont.c where
FLUID_FREE(sample->data) is called a couple of times. If this
sample->data pointer
is created in fluid_defsfont.c, it would be a problem, but I guess it

No, that should be safe. Defsfonts shouldn't try to interact with
ramsfonts anyway.

I've committed your patch now, after fixing a compiler warning and an
unprotected read of all_cached_sampledata. Thanks for your
contribution! :-)

Ouch! I see that. Thanks for checking and for committing the patch.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]