[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [fluid-dev] Calls to fluid_log()

From: Carlo Bramini
Subject: Re: [fluid-dev] Calls to fluid_log()
Date: Sat, 13 Oct 2018 11:34:49 +0200 (CEST)


> Il 10 ottobre 2018 alle 13.53 "Tom M." <address@hidden> ha scritto:
> > Since it comes for free, I do not see good reasons for not using FLUID_LOG 
> > macro also into those missing points.
> I don't see good reasons for keeping it. IMO it's redundant and could be 
> removed. Yet, I would accept a PR where FLUID_LOG is called everywhere. But 
> you should add one of those "good reasons" as comment pointing out why to 
> keep and use the macro rather than a direct function call. Otherwise it might 
> get removed in a future cleanup.
> And "removing logging completely" is not quite the reasoning I was hoping 
> for, as it raises the question why anyone should do that.

Well, for people who wants to strip a bit the size of the binary, I discovered 
that by commenting the FLUID_LOG, I'm able to reduce the size of the executable 
from 1.26MB to 1.18MB, without changing the current code. I tried to do also 
the few missing fixes into the sources that still need to replace fluid_log() 
with FLUID_LOG macro and I commented the content of the logging functions. The 
size decreased again from 1.18MB to 1.17MB, not so much but actually the 
biggest part of the code is already using FLUID_LOG macro, so it is normal.

So, it depends... if someone will like the idea to cut the size without 
affecting the the quality of the sound rendering (like me), probably he won't 
disregard the chance to have this FLUID_LOG macro. Besides the space gain and 
the fact that it is 99% already done, I do not other good reasons. Afterall, 
since logging is a slow code, it not called in vital points and removing it 
does not seem to provide performance improvements.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]