[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Freeipmi-devel] Re: [llnl-devel] New FreeIPMI API thouoghts

From: Anand Babu
Subject: [Freeipmi-devel] Re: [llnl-devel] New FreeIPMI API thouoghts
Date: Thu, 04 Dec 2003 17:51:40 -0800
User-agent: Gnus/5.1002 (Gnus v5.10.2) Emacs/21.3 (gnu/linux)

Albert Chu <address@hidden> writes:
>Good point.  However, I still find it unacceptable that that request
>packets are created such that session or request header data cannot
>be accessed in a clean manner.  Perhaps the interface should be made
>something like:
>assemble_pkt(rmcp_hdr_t *rmcp_hdr, ipmi_session_t *ipmi_session,
>             ipmi_request_hdr_t *ipmi_rq, void *ipmi_cmd, int 
>             ipmi_cmd_len, void *buffer, int buflen);
>To some extent mirror the unassemble functions.

You mean assemble_pkt will only memcpy those structures into a
byte-array and we will have to fill the values from outside?

>Then perhaps we need a "ping_assemble" function of some sort.  Requiring
>the user to do as you have in your ipmi-wrappper.c:
>  struct {
>    rmcp_hdr_t rmcp_hdr;
>    rmcp_asf_presence_ping_t asf_presence_ping;
>  } lan_pkt;
>  rmcp_asf_hdr (&lan_pkt.rmcp_hdr);
>  rmcp_asf_presence_ping (msg_tag, &lan_pkt.asf_presence_ping);
>  ipmi_lan_sendto(fd, &lan_pkt, sizeof(lan_pkt));
>I think is too much ... especially making the lan_pkt structure.

Yes, thats right. We need to write ping_assemble function.

Anand Babu
Office# +1-510-687-7045
Cell# +1-510-396-0717
Home# +1-510-894-0586

Free as in Freedom <>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]