Re: [Freetalk-dev] [PATCH] jabber iqs

[Anand Babu]

On Sat, Aug 12, 2006 at 08:26:48AM +0200, Matthias Quasthoff wrote:
,----
| The only thing still annoying me were those "unhandled iq" messages
| flooding my console. After some looking it seems any iq with
| type=get is handled as a disco#info in ft_msg_iq_handler, but later
| in the same function even this seems to get reported unhandled. My
| patch attached to this mail hopefully improves this behavior. I had
| to introduce two new functions ft_msg_iq_version_cb and
| ft_msg_iq_last_cb in order to handle the two most frequent
| queries. I put them into freetalk.cc, as they refer to the
| application's state. If you think they should go somewhere else,
| please tell me.
`----
Patch applied. Thanks!

,----
| Two more things I could implement (and which would be reusable for
| the jingle branch) are:
| 
| - Add libgalago and/or libnotify support, maybe even with
| avatars. This is not that interesting for me as long as no one knows
| if galago presence integration is to happen in Evolution/Thunderbird
| at all.
`----
Even I am not aware of it. But will be nice to see this
functionality. Because libjingle version is almost a rewrite, you
should really wait. Otherwise, lets ask Vikas to make his work public
in what ever stage it is. So you can help in other areas too.

,----
| - Make proud-of-freetalk rely on jabber:iq:version. For this, the
| jabber:iq:version result would have to reach proud-of-freetalk.scm
| some way. But it would be way more xmpp-ish :-)
`----
I wrote it when I was addicted to freehoo. Later ported with no effort
to freetalk. Initially it was more of optional module that user will
load if he is proud of using freehoo. Then after a while, I made it
load by default, because almost all of the users were really proud of
using freehoo :P. It had a hidden feature, You can find out from the
response even if the remote user is in "invisible" mode.

It is correct to re-implement proud-of-freetalk.scm using
jabber:iq:version. Please do so, but with the libjingle version.

One thing that annoys with jabber is missing "invisible" mode. Though
it has a more advanced interface to set visibility for selected users,
I find "/status invisible" more convenient. 

-- 
Anand Babu 
GPG Key ID: 0x62E15A31
Blog [http://ab.freeshell.org]              
The GNU Operating System [http://www.gnu.org]