freetype-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [freetype2] anuj-distance-field d5a98b1 4/4: [sdf] Added functions t


From: Anuj Verma
Subject: Re: [freetype2] anuj-distance-field d5a98b1 4/4: [sdf] Added functions to solve polynomial equations.
Date: Tue, 30 Jun 2020 19:35:44 +0530

> A minor thing: If there is a single statement in the block, the
> FreeType formatting is rather
>
> if ( b == 0 )
>    return 0;

Fixed. Thanks!

A few more things:

* Is the length of the comments okay?
 I feel like some of them are quite large, If
 they are unnecessary then I will try to reduce
 them.

* Can I safely fit the outline positions such as
  endpoints and control points in a 16.16 fixed
  point ?. At a few places I cast them from 26.6
  to 16.16 without overflow check.

Anuj


reply via email to

[Prev in Thread] Current Thread [Next in Thread]