Re: [ft-devel] Re: xorg crashes with freetype2-2.1.10

[Hin-Tak Leung]

Joe Marcus Clarke wrote:
> On Wed, 2005-07-20 at 06:16 +0100, Hin-Tak Leung wrote:
>
> > The ChangeLog entry does mention the specific change explicitly:
>
>
> Ah.  Still kind of cryptic, though.  _Why_ shouldn't they be used?

Well, not entirely cryptic - seems to be a rewrite with an 'enhanced bitmap
loader' for the changes in the same group.

> > 2005-02-28  David Turner  <address@hidden>
> > ...
> >         * src/sfnt/sfdriver.c (sfnt_interface)
> >         [TT_CONFIG_OPTION_EMBEDDED_BITMAPS]: Don't use `tt_find_sbit_image'
> >         and `tt_load_sbit_metrics'.
> > ...
> >
> > So the change is intentional. I just upgraded to stock freetype 2.1.10
> > (was using cvs-2004-dec-31), went around a few web pages with mozilla-xft,
> > and I don't have crashes. I am using xorg 6.8.2 on linux. How do you
> > trigger the crash?
>
>
> Honestly, I have been able to trigger the crash myself.  It appears to
> be triggered by a certain font (or set of fonts).  The Microsoft
> webfonts seem to be particularly problematic.

I have the microsoft fonts, actually, and I just changed mozilla-xft to use
specifically courier new (the one in your gdb backtrace) for display. No
crashes yet. Granted, mozilla-xft probably used it differently - *how* do you
trigger a crash? You do realise the font name is quite broken (seems to be
followed by garbage all the time) in your gdb bt?

"-webfonts-courier new-medium..."

may worth checking your font.dir - seems to be hand-edited - mine
is auto-generated by mkfontdir, and entry start with e.g.
"-microsoft-courier new-..."

> Joe
>
>
> > Joe Marcus Clarke wrote:
> >
> > > -----BEGIN PGP SIGNED MESSAGE-----
> > > Hash: SHA1
> > >
> > > Hin-Tak Leung wrote:
> > > | Found the CVS entry:
> > > |
> > > |
> > > http://savannah.nongnu.org/cgi-bin/viewcvs/freetype/freetype2/src/sfnt/sfdriver.c.diff?r1=1.71&r2=1.72 
> > >
> > >
> > > |
> > > |
> > > |
> > > |   * include/freetype/internal/tttypes.h, src/sfnt/ttsbit.c,
> > > | src/sfnt/ttsbit0.c,
> > > |   src/truetype/ttobjs.c, src/cff/cffobjs.c, src/sfnt/sfobjs.c:
> > > | implementing new
> > > |   heap-optimized embedded bitmap loader. This one also fixes bug #12107
> > > |
> > > | checked in by user 'freetype' (David Turner?). they were changed to NULL,
> > > | then to zero - there must be a reason?
> > >
> > > Yes, there must be a reason, but that commit message doesn't list
> > > sfdriver.c explicitly.  That's why I was wondering what the exact reason
> > > was for the change, and what new steps should be done to get similar
> > > results from FT.
> > >
> > > Joe
> > >
> > > |
> > > | Jeremy Messenger wrote:
> > > |
> > > |> On Sun, 17 Jul 2005 15:24:40 -0500, Joe Marcus Clarke
> > > |> <address@hidden>  wrote:
> > > |>
> > > |>> Looks like the freetype module in xorg (and XFree86) makes reference to
> > > |>> SFNT_Service->find_sbit_image which is now 0 in FT 2.1.10 (it used 
> > > to be
> > > |>> initialized to tt_find_sbit_image).  This causes X to die rather
> > > |>> abruptly when trying to dereference this symbol:
> > > |>>
> > > |>> http://people.freebsd.org/~mezz/gdb/gdb-freetype2.txt
> > > |>>
> > > |>> I assume this was done by design in FT (though I couldn't find a commit
> > > |>> message that said spoke about this particular change).  If so, what
> > > |>> should X be doing to correctly obtain the glyph sbit?  Thanks!
> > > |>
> > > |>
> > > |>
> > > |> I have solved the crash. I have been using it for the thirty minutes
> > > |> and  no crash so far. If I do unpatch and it will crash within five
> > > |> minutes.  Here's patch to put in freetype2/files. Don't know if patch
> > > |> is right, but  at least it's fixed for me.
> > > |>
> > > |> http://people.freebsd.org/~mezz/patch-src::sfnt::sfdriver.c
> > > |>
> > > |> I found it by compared freetype2 2.1.9 and 2.1.10, you can check if
> > > |> you  want to see for youself. I removed compare of Makefile, configure
> > > |> and  other useless stuff.
> > > |>
> > > |> http://people.freebsd.org/~mezz/freetype2-compare.diff.bz2
> > > |>
> > > |> It looks like 2.1.10 removed or disabled *find_sbit_image? Search for
> > > |> 'find_sbit_image' in freetype2-compare.diff.bz2.
> > > |>
> > > |> Cheers,
> > > |> Mezz
> > > |>
> > > |>> Joe
> > > |>
> > > |>
> > > |>
> > > |>
> > > |
> > > |
> > > | ___________________________________________________________ How much
> > > | free photo storage do you get? Store your holiday snaps for FREE with
> > > | Yahoo! Photos http://uk.photos.yahoo.com
> > > |
> > >
> > >
> > > - --
> > > Joe Marcus Clarke
> > > FreeBSD GNOME Team    ::    address@hidden
> > > FreeNode / #freebsd-gnome
> > > http://www.FreeBSD.org/gnome
> > > -----BEGIN PGP SIGNATURE-----
> > > Version: GnuPG v1.4.1 (Darwin)
> > > Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
> > >
> > > iD8DBQFC3W+rb2iPiv4Uz4cRArfoAJ4tP/XRPRwWykuQL+DZmGldgwCBOgCfZrNl
> > > ts1bAb9rB9D1InM6I8QuhcA=
> > > =T1sX
> > > -----END PGP SIGNATURE-----
> >
> >         
> >         
> >                 
> > ___________________________________________________________ 
> > Yahoo! Messenger - NEW crystal clear PC to PC calling worldwide with voicemail http://uk.messenger.yahoo.com

        
        
                
___________________________________________________________ 
Yahoo! Messenger - NEW crystal clear PC to PC calling worldwide with voicemail http://uk.messenger.yahoo.com