freetype-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ft-devel] [PATCH] Improve FT_MulFix


From: Werner LEMBERG
Subject: Re: [ft-devel] [PATCH] Improve FT_MulFix
Date: Wed, 06 Apr 2011 01:04:47 +0200 (CEST)

>> WL> Please redo the patch so that the old code gets saved within a #if 0
>> WL> ... #endif clause (to stay as a reference),
>> 
>> (having the old code in the repo’s history is not enough? :^)
> 
> I agree with James.  Disabled code only clutters the code base...

In most circumstances, I fully agree.  However, the new code looks
like voodoo to me, and the used trick is something I don't consider as
easily understandable.  For this reason I like to have the old code as
a kind of reference.  But perhaps it's just me who is too dumb here.

If you prefer, the old code can be moved into a comment, but there are
enough precedences of #if 0 ... #endif within FreeType.


    Werner

reply via email to

[Prev in Thread] Current Thread [Next in Thread]