[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ft-devel] WIP PATCH: clang static analyzer and warning fixes

From: Alexei Podtelezhnikov
Subject: Re: [ft-devel] WIP PATCH: clang static analyzer and warning fixes
Date: Tue, 17 Jun 2014 20:47:13 -0400

On Tue, Jun 17, 2014 at 10:29 AM, Sean McBride <address@hidden> wrote:
On Mon, 16 Jun 2014 20:46:44 -0400, Alexei Podtelezhnikov said:

>> > Arghhhh... I am not sure if the patch is even correct.  Aren't we
>> > resetting the variable in each loop cycle?  This wasn't the case in
>> > the original code where the values reused, was it?
>> Oops!  You are right.  Thanks for catching this; it's now reverted.
>Arghhhh!!! This thing (aflatin.c:571) got wrongly "fixed" again. Please
>revert with an inline comment so that people think rather than trust clang.

I submit that there is a code smell here.  The code is funky enough to trick two different tools, humans, and human reviewers.  While it may be 'correct', it's probably too complicated and should be refactored in some way.

It is a hack of code! I'll try to understand it fully and rework. You are welcome to do that too.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]