[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [ft-devel] FT_Vector_NormLen: faster vector normalization
|
From: |
Werner LEMBERG |
|
Subject: |
Re: [ft-devel] FT_Vector_NormLen: faster vector normalization |
|
Date: |
Tue, 28 Jul 2015 07:26:04 +0200 (CEST) |
>> My last commit should remove all conversion warnings.
I still get one warning:
ftcalc.c:870:17: warning: implicit conversion changes signedness:
'int' to 'FT_UInt32' (aka 'unsigned int') [-Wsign-conversion]
l = 0x10000 + (FT_Int32)( u * x + v * y ) / 0x10000;
~ ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Can you fix this also, please? And please improve the comment
w.r.t. `signed difference', since it is not obvious to me what effect
you are achieving here – inspite of making it probably uglier to read,
proper casts are *necessary* IMHO in this very line to make it simpler
to understand.
Werner