Re: [ft-devel] problems with your branch

[Werner LEMBERG]

>> 10. Looking at the HTML output for sizes 16 and 20 of `test.ttf'
>>     (using 72dpi and rendering mode 2), then switching between
>>     sizes 16 and 20, I see that the scaling of the glyph doesn't
>>     fit – the used glyph scaling values should be integer multiples
>>     and nothing else...
> 
> I don't clearly understand. Please elaborate.

Attached are two screenshots (using current git) with my Chrome
browser.  In the 96dpi snapshot, the exclamation mark is *smaller*
than in the 72dpi snapshot, which indicates that the glyph image
scaling is completely out of control...  The results with Firefox
are roughly the same.

BTW, if I scroll down, then change a viewing option (e.g., switching
from 16 to 20), I'm taken to the top line so that I have to scroll
down again.  It would be nice if this could be avoided somehow.

Another thing to add is some text to `top.html' which shortly explains
to the user what she or he is seeing.  In particular, it should also
show the paths to the used DLLs.  And please replace `Size' with
`Size (pt)' or `Point Size'.

> Also the attached Makefile.diff is empty.
> Please send it again.

Oops.  Attached also.

Some other minor things for `runme.sh'.

. Please make FT_TEST_TEST_DLL overridable also.

. You are now using arrays.  Since this is a bash extension you should
  start the script with the proper shebang:

    #! /bin/bash

  This is the quick solution.  A better one is probably to avoid
  bashisms altogether (the tests should work on as much platforms as
  possible), teaching `make_sprite' to understand render mode strings.

. The shell is line oriented, so please remove all unnecessary
  trailing `;' characters.

BTW, will you be able to make the sprite feature actually work,
probably with zooming?  Right now I see four glyphs side by side,
which doesn't help much.


     Werner

diff --git a/tests/make_png/Makefile b/tests/make_png/Makefile
index 5e49d58db..695327c92 100644
--- a/tests/make_png/Makefile
+++ b/tests/make_png/Makefile
@@ -4,9 +4,6 @@ BUILD_DIR := $(TOP_DIR)/builds/unix
 include $(TOP_DIR)/builds/unix/unix-def.mk
 
 SRC_SPRITE = make_sprite.c bitmap.c murmur3.c
-SRC_LIB = $(libdir)/libfreetype.a
-
-OBJS = $(src:.c=.o)
 
 CFLAGS = -Wall -g
 CC = gcc
@@ -16,7 +13,7 @@ LIBS = -lpng -lharfbuzz -lbz2 -ldl
 all: tests
 
 tests: $(SRC_SPRITE)
-       $(CC) $(CFLAGS) $(INCLUDE) -o $@  $(SRC_SPRITE) $(SRC_LIB) $(OBJS) 
$(LIBS)
+       $(CC) $(CFLAGS) $(INCLUDE) -o $@ $^ $(LIBS)
 
 .PHONY: clean force
 clean: