[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: I haved resolved font Italic for FT_GLYPH_FORMAT_BITMAP, this is my
From: |
Alexei Podtelezhnikov |
Subject: |
Re: I haved resolved font Italic for FT_GLYPH_FORMAT_BITMAP, this is my code |
Date: |
Mon, 12 Apr 2021 09:18:23 -0400 |
Hi Liu,
Thank you for your contribution. I understand the idea of shear
transformation applied to bitmaps. However, your implementation is
incomplete and not suitable for FreeType just yet.
> 1. ftbitmap.h
> FT_EXPORT( FT_Error )
> FT_Bitmap_Italic(
> FT_Library library,
> FT_Bitmap* bitmap,
> FT_Pos xStrength,
> FT_Pos yStrength );
In actuality you only implement horizontal shear. Also I think
negative xStrength is mishandled. It only matters if offset decreases
or increases from top to bottom.
> 2. ftbitmap.c
>
> #define TAISHAN_FONT_ITALIC_VALUE 0.20F
FreeType does not use floating numbers and it needs to be explained.
Why divide by 5 and not 4? You do not even use newWidth.
Please clean up you by removing all irrelevant variables and code.
Thank you,
Alexei