Re: ftbench update: make integrated

Sorry, my bad to forget to add CC.
I thought you mean running make outside of the src/tools/ftbench file (as how older version works) by non-sourcedir builds. if you mean running from a seperate build directory, it is working now.

for benchmark.html (also in the attachments):

*changed .txts to font name and extension

*added another column that shows the difference in

percent

*added warning message

*shorten commit id and linking to gitlab

*parameters and stuff are being printed once

for testing.mk:

`make baseline` is working from a separate build directory.

(the error were caused by trying to reach to git details from different directory, solved it by "git -C $(TOP_DIR)”)

here are the things i stucked:

1) renaming bench.o to bench

i am getting this error when i trim the extension .o:

Building ftbench...
libtool: error: cannot determine name of library object from '/Users/gks/Desktop/freetype/objs/bench'
make: *** [/Users/gks/Desktop/freetype/objs/bench] Error 1

here is the makefile part related to this.

INCLUDES = -I$(TOP_DIR)/include

# Build ftbench
$(FTBENCH_BIN): $(FTBENCH_SRC) | $(OBJ_DIR)
@echo "Building ftbench..."
@$(CC) $(INCLUDES) $< -lfreetype -o $@

2) multiple compiles of ftbench:

Building ftbench...
./builds/unix/libtool --mode=compile gcc -I/Users/gks/Desktop/freetype/include /Users/gks/Desktop/freetype/src/tools/ftbench/ftbench.c -lfreetype -o /Users/gks/Desktop/freetype/objs/bench.o
libtool: compile: gcc -I/Users/gks/Desktop/freetype/include /Users/gks/Desktop/freetype/src/tools/ftbench/ftbench.c -lfreetype -fno-common -DPIC -o /Users/gks/Desktop/freetype/objs/.libs/bench.o
libtool: compile: gcc -I/Users/gks/Desktop/freetype/include /Users/gks/Desktop/freetype/src/tools/ftbench/ftbench.c -lfreetype -o /Users/gks/Desktop/freetype/objs/bench.o >/dev/null 2>&1

i tried both with gcc and it works well. i think i am missing a point related to libtool (parameter?). i need some hint to fix these.

On 2 Jul 2023 18:55 +0300, Werner LEMBERG <wl@gnu.org>, wrote:

Is it seem enough to pass mid-term evaluations or is there any other
improvements needed before the date?

Looks good in general, and see the other e-mail with a list of tasks.
By the way, it would be nice if you actually did *all* the things I'm
asking for — IIRC, this is the third time I'm talking about
non-sourcedir builds, and it still doesn't work.

Werner

From:	Ahmet Göksu
Subject:	Re: ftbench update: make integrated
Date:	Wed, 5 Jul 2023 14:35:11 +0300

Info	Baseline	Benchmark
Parameters	-c 200	-c 200
Commit ID	1afa5619	1afa5619
Commit Date	2023-07-05 14:00:12 +0300	2023-07-05 14:00:12 +0300
Branch	GSoC-2023-Ahmet	GSoC-2023-Ahmet

Test	Baseline	Benchmark	Difference
Load	5.48 us/op	4.90 us/op	10.61%
Load_Advances (Normal)	5.65 us/op	5.34 us/op	5.40%
Load_Advances (Fast)	0.03 us/op	0.03 us/op	21.21%
Load_Advances (Unscaled)	0.04 us/op	0.02 us/op	36.84%
Render	4.07 us/op	3.70 us/op	9.12%
Get_Glyph	1.65 us/op	1.48 us/op	10.61%
Get_Char_Index	0.03 us/op	0.03 us/op	-6.90%
New_Face	54.10 us/op	43.62 us/op	19.37%
Embolden	2.07 us/op	1.93 us/op	6.90%
Stroke	34.27 us/op	30.12 us/op	12.13%
Get_BBox	1.10 us/op	0.97 us/op	11.67%
Get_CBox	0.90 us/op	0.78 us/op	13.56%

Test	Baseline	Benchmark	Difference
Load	8.33 us/op	8.16 us/op	1.98%
Load_Advances (Normal)	9.55 us/op	7.87 us/op	17.57%
Load_Advances (Fast)	0.03 us/op	0.03 us/op	-3.85%
Load_Advances (Unscaled)	0.03 us/op	0.03 us/op	0.00%
Render	4.16 us/op	3.77 us/op	9.42%
Get_Glyph	2.08 us/op	1.79 us/op	13.76%
Get_Char_Index	0.03 us/op	0.03 us/op	-3.45%
New_Face	65.28 us/op	52.30 us/op	19.89%
Embolden	2.38 us/op	2.19 us/op	7.89%
Stroke	30.57 us/op	29.06 us/op	4.96%
Get_BBox	1.18 us/op	1.12 us/op	5.33%
Get_CBox	1.01 us/op	0.79 us/op	22.01%

Test	Baseline	Benchmark	Difference
Load	13.59 us/op	9.65 us/op	28.99%
Load_Advances (Normal)	13.02 us/op	8.98 us/op	31.03%
Load_Advances (Fast)	0.03 us/op	0.03 us/op	7.14%
Load_Advances (Unscaled)	0.03 us/op	0.03 us/op	3.85%
Render	4.43 us/op	4.42 us/op	0.34%
Get_Glyph	1.86 us/op	1.92 us/op	-3.22%
Get_Char_Index	0.03 us/op	0.03 us/op	-3.23%
New_Face	61.99 us/op	60.97 us/op	1.65%
Embolden	3.66 us/op	3.03 us/op	17.17%
Stroke	45.36 us/op	39.35 us/op	13.25%
Get_BBox	1.30 us/op	1.26 us/op	2.62%
Get_CBox	0.89 us/op	0.80 us/op	9.70%

Re: ftbench update: make integrated

Benchmark Results

Warning: Baseline and Benchmark have the same commit ID

Info

Results for Roboto_subset.ttf

Results for Arial_subset.ttf

Results for TimesNewRoman_subset.ttf

Results for Tahoma_subset.ttf

Results for Verdana_subset.ttf

Test	Baseline	Benchmark	Difference
Load	5.93 us/op	5.06 us/op	14.73%
Load_Advances (Normal)	6.64 us/op	5.71 us/op	14.06%
Load_Advances (Fast)	0.03 us/op	0.03 us/op	0.00%
Load_Advances (Unscaled)	0.03 us/op	0.02 us/op	4.00%
Render	4.18 us/op	3.73 us/op	10.78%
Get_Glyph	2.10 us/op	1.67 us/op	20.59%
Get_Char_Index	0.03 us/op	0.03 us/op	6.67%
New_Face	63.95 us/op	52.16 us/op	18.44%
Embolden	2.70 us/op	2.36 us/op	12.64%
Stroke	31.08 us/op	26.98 us/op	13.20%
Get_BBox	1.36 us/op	1.01 us/op	25.75%
Get_CBox	1.13 us/op	0.77 us/op	31.89%

Test	Baseline	Benchmark	Difference
Load	6.28 us/op	4.65 us/op	25.92%
Load_Advances (Normal)	5.23 us/op	5.32 us/op	-1.68%
Load_Advances (Fast)	0.03 us/op	0.03 us/op	3.70%
Load_Advances (Unscaled)	0.02 us/op	0.02 us/op	0.00%
Render	4.09 us/op	3.61 us/op	11.76%
Get_Glyph	1.85 us/op	1.64 us/op	11.16%
Get_Char_Index	0.03 us/op	0.03 us/op	-3.57%
New_Face	52.13 us/op	48.95 us/op	6.10%
Embolden	2.41 us/op	2.19 us/op	8.96%
Stroke	26.89 us/op	26.52 us/op	1.37%
Get_BBox	1.02 us/op	1.06 us/op	-4.31%
Get_CBox	0.90 us/op	0.74 us/op	18.16%