[Gcjwebplugin-devel] Patch: StandaloneAppletWindow fix and Test

[Lillian Angel]

I spoke to fitzsim, and he suggested we do the same in our
StandaloneAppletWindow (even though Sun does not). I agree it is a cool
feature to have. Try out this applet in the standalone on Classpath and
Sun: 
gcjappletviewer http://www.falstad.com/wavebox/

Attached is the updated test case, the other one did not work as well as
I initially expected. The events need to be triggered directly on the
*AppletWindow, for the test to work. The test case is alot smaller, but
demonstrates why these changes are required.

Again, I do not have commit access, but I believe fitzsim will commit it
for me.


06-04-2006  Lillian Angel  <address@hidden>

        * src/gcjwebplugin/StandaloneAppletWindow.java
        (StandaloneAppletWindow): Added listeners.
        (componentAdded): New function. Passes event to applet.
        (componentRemoved): Likewise.
        (componentHidden): Likewise.
        (componentShown): Likewise.
        (componentResized): Likewise.
        (componentMoved): Likewise.
        (mouseClicked): Likewise.
        (mousePressed): Likewise.
        (mouseReleased): Likewise.
        (mouseEntered): Likewise.
        (mouseExited): Likewise.
        (mouseDragged): Likewise.
        (mouseMoved): Likewise.
        (inputMethodTextChanged): Likewise.
        (caretPositionChanged): Likewise.
        (hierarchyChanged): Likewise.
        (ancestorMoved): Likewise.
        (ancestorResized): Likewise.

On Fri, 2006-04-07 at 12:56 -0400, Lillian Angel wrote:
> On Thu, 2006-04-06 at 18:26 -0400, Lillian Angel wrote:
> > Hi,
> > 
> > Attached is a fix for PluginAppletWindow. It should extend several
> > different listeners, and pass all events received to its child (the
> > applet). This is because the author of the applet may attach a listener
> > to the applet, as they are unaware of the parent frame (the plugin
> > applet window), and any events on the parent window will not be known to
> > the child and the it's listener will never be notified.
> > 
> > Try this applet: http://www.falstad.com/wavebox/
> > 
> > The PluginAppletWindow implements all listeners that Sun's appletWindow
> > implements. Sun does not take care of all listeners (i.e. FocusListener
> > and KeyListener) but most are there. The test case tests all listeners.
> > It completely passes on Sun. 3 tests fail on gcjwebplugin because of a
> > Classpath bug. This will be fixed soon.
> 
> The problem has been fixed in Classpath. All tests pass.
> 
> > 
> > 06-04-2006  Lillian Angel  <address@hidden>
> > 
> >     * src/gcjwebplugin/PluginAppletWindow.java
> >     (PluginAppletWindow): Added listeners.
> >     (componentAdded): New function. Passes event to applet.
> >     (componentRemoved): Likewise.
> >     (componentHidden): Likewise.
> >     (componentShown): Likewise.
> >     (componentResized): Likewise.
> >     (componentMoved): Likewise.
> >     (mouseClicked): Likewise.
> >     (mousePressed): Likewise.
> >     (mouseReleased): Likewise.
> >     (mouseEntered): Likewise.
> >     (mouseExited): Likewise.
> >     (mouseDragged): Likewise.
> >     (mouseMoved): Likewise.
> >     (inputMethodTextChanged): Likewise.
> >     (caretPositionChanged): Likewise.
> >     (hierarchyChanged): Likewise.
> >     (ancestorMoved): Likewise.
> >     (ancestorResized): Likewise.
> >     (setHandle): No need to set layout here.
> > 
> > I do not have commit access, can someone please commit this?
> > 
> > Thank you,
> > Lillian
> > _______________________________________________
> > Gcjwebplugin-devel mailing list
> > address@hidden
> > http://lists.nongnu.org/mailman/listinfo/gcjwebplugin-devel
> 
> 
> 
> _______________________________________________
> Gcjwebplugin-devel mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/gcjwebplugin-devel

patch.diff
Description: Text Data

TestAppletListeners.java
Description: Text Data