[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Getfem-commits] Could you merge 4 branchs

From: Yves Renard
Subject: Re: [Getfem-commits] Could you merge 4 branchs
Date: Sun, 23 Feb 2020 17:25:59 +0100 (CET)

Dear Tetsuo,

Thank you for these contributions and fixes. This is merged in the master 

Best regards,


----- Mail original -----
De: "Tetsuo Koyama" <address@hidden>
À: "getfem-commits" <address@hidden>
Envoyé: Dimanche 23 Février 2020 09:29:56
Objet: [Getfem-commits] Could you merge 4 branchs

Dear getfem proejct

Could you review and merge 4 branchs?
1 is API adding and 3 is very small fix.

1. devel-tetsuo-outer_faces_in_ball
I added outer_faces_in_ball to python API and select_faces_in_ball to C++ API.
It makes easy to select region in ball shape.
I know we can select convex and faces by using numpy, but this API
save that work.
(I really like GetFEM++'s mesh API.)

2. devel-tetsuo-cleanup
Variable 'is_set' is assigned a value that is never used.  I deleted
it in interface/src/ .

3. tetsuo-comment-of-pts-from-cvid
I made a small fix of message in gmm to show me what is the wrong of use.

4. tetsuo-comment-of-pts-from-cvid
My friend @phduckie said that in GetFEEM++ Python API document it is
not clear that what is returned from function. So I changed the
comment of function a little which is used for documentation.
Thank @phduckie for your comment.

Best Regard Tetsuo

reply via email to

[Prev in Thread] Current Thread [Next in Thread]