Re: [glob2-devel] temp variables in settings, no clean, not required

[donkyhotay]

I'll confess to writing that section of code. Go ahead and change it if
you want, you won't hurt my feelings as I know your right about it being
ugly. 



On Sun, 2006-12-31 at 12:48 +0100, Stéphane Magnenat wrote:
> Hi,
> 
> I've seen there is temp variables in settings used for communication between 
> the GUI and the game. That's not clean, settings class should be used to 
> stored settings, and only that.
> 
> Two of those variables:
>       int tempUnit;
>       int tempUnitFuture;
> could be removed by passing parameters from orders to buildings as function 
> arguments.
> 
> The rest of those variables:
>       int BUILDING_NAME_Temp_LEVEL_[c];
> should be stored in GameGUI as a std::valarray of size BuildingsTypes.size()
> 
> I don't want to be rude an change people's code behind their head so I would 
> like to have the agreament of the coder of that part prior to change.
> 
> Thanks, have a nice day,
> 
> Steph
> 
-- 
Do not be afraid to joust a giant just because some people insist on
believing in windmills.