|
From: | Vijay Bellur |
Subject: | [Gluster-devel] Proposed change in Gerrit workflow |
Date: | Tue, 25 Sep 2012 16:13:11 +0530 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 |
Hi All, We intend to bring the following change in our gerrit based workflow: - Introduce +2 and -2 for Verified in Gerrit - +2 for Verified to be necessary for merging a patchThe intent of this proposed change is to get additional test coverage and reduce the number of regressions that can sneak by. Jenkins would continue to provide +1s for all submitted changes that pass basic smoke tests. An additional +2 would be necessary from somebody who tests the patch. Providing a +2 for Verified would be semantically similar to adding a Tested-by: tag.
Note that +1s are not additive in gerrit and hence a +2 verified would be necessary in addition to the +1 provided by Jenkins. Over time test scripts developed for verification can find a place in extras/test or in a better framework.
Please let us know your suggestions, comments or objections regarding this approach. If there are no objections, we will roll this change out by 09/28.
Thanks, Vijay
[Prev in Thread] | Current Thread | [Next in Thread] |