[Gnash-commit] gnash ChangeLog libbase/log.cpp server/ActionEx...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  06/07/25 19:54:40

Modified files:
        .              : ChangeLog 
        libbase        : log.cpp 
        server         : ActionExec.cpp 

Log message:
                * libbase/log.cpp: another small optimization.
                * server/ActionExec.cpp: don't call stack dumper
                  unless -va is given (another optimization)

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.516&r2=1.517
http://cvs.savannah.gnu.org/viewcvs/gnash/libbase/log.cpp?cvsroot=gnash&r1=1.14&r2=1.15
http://cvs.savannah.gnu.org/viewcvs/gnash/server/ActionExec.cpp?cvsroot=gnash&r1=1.15&r2=1.16

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.516
retrieving revision 1.517
diff -u -b -r1.516 -r1.517
--- ChangeLog   25 Jul 2006 19:27:54 -0000      1.516
+++ ChangeLog   25 Jul 2006 19:54:40 -0000      1.517
@@ -1,3 +1,9 @@
+2006-07-25 Sandro Santilli <address@hidden>
+
+       * libbase/log.cpp: another small optimization.
+       * server/ActionExec.cpp: don't call stack dumper
+         unless -va is given (another optimization)
+
 2006-07-25 Bastiaan Jacques <address@hidden>
 
        * configure.ac: The correct option is --enable-plugin, not

Index: libbase/log.cpp
===================================================================
RCS file: /sources/gnash/gnash/libbase/log.cpp,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -b -r1.14 -r1.15
--- libbase/log.cpp     25 Jul 2006 16:55:21 -0000      1.14
+++ libbase/log.cpp     25 Jul 2006 19:54:40 -0000      1.15
@@ -195,27 +195,32 @@
 void
 log_action(const char* fmt, ...)
 {
-       bool stamp = dbglogfile.getStamp();
-       dbglogfile.setStamp(false);
-       if (dbglogfile.getActionDump())
+    if ( ! dbglogfile.getActionDump() )
        {
+        return;
+    }
+
                va_list ap;
                char tmp[BUFFER_SIZE];
 
                va_start (ap, fmt);
                vsnprintf (tmp, BUFFER_SIZE, fmt, ap);
-               tmp[BUFFER_SIZE - 1] = '\0';
-    va_end (ap);    
+    tmp[BUFFER_SIZE-1] = '\0';
 
+    bool stamp = dbglogfile.getStamp();
+    dbglogfile.setStamp(false);
                dbglogfile << tmp << endl;
-       }
        dbglogfile.setStamp(stamp);
-    
 }
 
 void
 log_parse(const char* fmt, ...)
 {
+    if ( ! dbglogfile.getParserDump() )
+    {
+        return;
+    }
+
     va_list ap;
     char tmp[BUFFER_SIZE];
 
@@ -223,9 +228,7 @@
     vsnprintf (tmp, BUFFER_SIZE, fmt, ap);
     tmp[BUFFER_SIZE-1] = '\0';
 
-    if (dbglogfile.getParserDump()) {
        dbglogfile << tmp << endl;
-    }
     
     va_end (ap);    
 }

Index: server/ActionExec.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/ActionExec.cpp,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -b -r1.15 -r1.16
--- server/ActionExec.cpp       17 Jul 2006 01:22:32 -0000      1.15
+++ server/ActionExec.cpp       25 Jul 2006 19:54:40 -0000      1.16
@@ -130,12 +130,14 @@
     //UNUSED(original_target);         // Avoid warnings.
 
 #if DEBUG_STACK
+       if (dbglogfile.getActionDump()) {
         log_action("at ActionExec operator() start, pc=%zd, stop_pc=%zd, 
code.size=%zd.", pc, stop_pc, code.size());
        stringstream ss;
        env.dump_stack(ss);
        env.dump_global_registers(ss);
        env.dump_local_registers(ss);
        log_action("%s", ss.str().c_str());
+       }
 #endif
 
     while (pc<stop_pc)