[Gnash-commit] gnash ChangeLog backend/sound_handler_gst.cpp

[Tomas Groth]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Tomas Groth <tgc>       06/07/27 17:08:36

Modified files:
        .              : ChangeLog 
        backend        : sound_handler_gst.cpp 

Log message:
        Made the gst-sound log messages more informative

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.540&r2=1.541
http://cvs.savannah.gnu.org/viewcvs/gnash/backend/sound_handler_gst.cpp?cvsroot=gnash&r1=1.8&r2=1.9

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.540
retrieving revision 1.541
diff -u -b -r1.540 -r1.541
--- ChangeLog   27 Jul 2006 14:54:42 -0000      1.540
+++ ChangeLog   27 Jul 2006 17:08:36 -0000      1.541
@@ -1,3 +1,8 @@
+2006-07-27 Tomas Groth Christensen <address@hidden>
+
+        * backend/sound_handler_gst.cpp: Made the log messages more 
informative.
+
+
 2006-07-27 Bastiaan Jacques <address@hidden>
 
        * configure.ac: Allow us to specify --enable-sound=none. Default to

Index: backend/sound_handler_gst.cpp
===================================================================
RCS file: /sources/gnash/gnash/backend/sound_handler_gst.cpp,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -b -r1.8 -r1.9
--- backend/sound_handler_gst.cpp       27 Jul 2006 12:11:37 -0000      1.8
+++ backend/sound_handler_gst.cpp       27 Jul 2006 17:08:36 -0000      1.9
@@ -19,14 +19,6 @@
 // which has been donated to the Public Domain.
 
 
-/*  TODO:
-       * dealloker elementer efter brug (sinkXX stiger: 1go_menu.swf) brug 
bus_callback'en? event_probe!
-       * hvordan fikser vi traaden? stopper vi loop, eller pauser vi 
pipelinen? Begge dele! :)
-       * streams
-       * Not really a todo... ATM Gstreamer can't handle multiple elements 
trying to cennect at the same time.
-*/
-
-
 #ifdef HAVE_CONFIG_H
 #include "config.h"
 #endif
@@ -145,8 +137,14 @@
                if (!audiosink) audiosink = gst_element_factory_make 
("esdsink", NULL);
 
                // Check if the creation of the gstreamer pipeline, adder and 
audiosink was a succes
-               if (!pipeline || !adder || !audiosink) {
-                       gnash::log_error("One gstreamer element could not be 
created\n");
+               if (!pipeline) {
+                       gnash::log_error("The gstreamer pipeline element could 
not be created\n");
+               }
+               if (!adder) {
+                       gnash::log_error("The gstreamer adder element could not 
be created\n");
+               }
+               if (!audiosink) {
+                       gnash::log_error("The gstreamer audiosink element could 
not be created\n");
                }
 
                // link adder and output to bin
@@ -410,7 +408,7 @@
                        || !gst_element->audioconvert
                        || !gst_element->audioresample) {
 
-                       gnash::log_error("One gstreamer element could not be 
created\n");
+                       gnash::log_error("Gstreamer element for audio handling 
could not be created\n");
                        return;
                }