gnash-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] gnash/server dlist.cpp


From: Bastiaan Jacques
Subject: Re: [Gnash-commit] gnash/server dlist.cpp
Date: Thu, 24 Aug 2006 02:18:43 +0200
User-agent: KMail/1.9.4

On Thursday 24 August 2006 01:44, strk wrote:
> Guys, I just realized that we might be talking about nothing here.
> The DisplayList is a std::list, so as any insertion or deletion
> would still keep the same end() value, and would never invalidate
> an iterator, right ?

You're quite right, and this means that the original code (before 
Vitaly's commit) was correct.

> I'd ask Vitaly to provide a testcase justifying his change.
> Also, the previous code was checking for size() change, and
> warning user if it happened.

So at least the commenting out of said warning was a useful change. ;)

Bastiaan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]