[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-commit] gnash/macros ffmpeg.m4
From: |
strk |
Subject: |
Re: [Gnash-commit] gnash/macros ffmpeg.m4 |
Date: |
Mon, 9 Oct 2006 10:31:59 +0200 |
On Sat, Oct 07, 2006 at 09:30:13PM +0000, Markus Gothe wrote:
> CVSROOT: /sources/gnash
> Module name: gnash
> Changes by: Markus Gothe <nihilus> 06/10/07 21:30:13
>
> Modified files:
> macros : ffmpeg.m4
>
> Log message:
> Run AM_CONDITIONAL rather than AC_DEFINE.
mm... I think AC_DEFINE was correct.
The checks should only set defines as for HAVE_THIS_AND_THAT
while the configure.ac main file should use AM_CONDITIONAL
based on other user input. For example, even if I *do* have
gstreamer, that deosnt' mean I want to use it (--enable-this-and-that).
So, the .m4 files shoudl just AC_DEFINE (and we do want
the config.h file to reflect reality).
BTW, since we don't check for stuff if not requested in ./configure
now, we'll end up with config.h containing wrong info, for examlpe
HAVE_WHATEVER undefined when WHATEVER is really there but not
requested by user (this might be a minor thing)
--strk;