[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-commit] gnash ChangeLog macros/atk.m4 macros/ffmpeg.m4 ...
From: |
strk |
Subject: |
Re: [Gnash-commit] gnash ChangeLog macros/atk.m4 macros/ffmpeg.m4 ... |
Date: |
Mon, 9 Oct 2006 11:31:44 +0200 |
On Sat, Oct 07, 2006 at 09:10:20PM +0000, Markus Gothe wrote:
> CVSROOT: /sources/gnash
> Index: macros/gstreamer.m4
> ===================================================================
> RCS file: /sources/gnash/gnash/macros/gstreamer.m4,v
> retrieving revision 1.15
> retrieving revision 1.16
> diff -u -b -r1.15 -r1.16
> --- macros/gstreamer.m4 27 Jul 2006 14:28:28 -0000 1.15
> +++ macros/gstreamer.m4 7 Oct 2006 21:10:20 -0000 1.16
> @@ -49,7 +51,7 @@
> fi])
>
> dnl Try with pkg-config
> - if test x"$PKG_CONFIG" != x -a x"${ac_cv_path_gstreamer_incl}" = x; then
> + if test x"$PKG_CONFIG --exists gstreamer-0.10" = x -a
> x"${ac_cv_path_gstreamer_incl}" = x; then
> ac_cv_path_gstreamer_incl=`$PKG_CONFIG --cflags gstreamer-0.10`
> fi
>
> @@ -100,7 +102,7 @@
> ])
>
> dnl Try with pkg-config
> - if test x"$PKG_CONFIG" != x -a x"${ac_cv_path_gstreamer_lib}" = x; then
> + if test x"$PKG_CONFIG --exists gstreamer-0.10" = x -a
> x"${ac_cv_path_gstreamer_lib}" = x; then
> ac_cv_path_gstreamer_lib=`$PKG_CONFIG --libs gstreamer-0.10`
> fi
The below test would always fail:
test x"command" = x
You're testing 2 strings....
Please revert this patch, the PKG_CONFIG != x check checked for PKG_CONFIG
to be available. If you want to use --exists do it w/out involving the
'test' command.
--strk;