[Gnash-commit] gnash ChangeLog server/asobj/Global.cpp testsui...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  07/01/11 13:29:32

Modified files:
        .              : ChangeLog 
        server/asobj   : Global.cpp 
        testsuite/actionscript.all: Camera.as 

Log message:
                * server/asobj/Global.cpp: always provide the Function
                  and System classes. Add a note about possibly bogus
                  approach of making classes available based on SWF
                  version.
                * testsuite/actionscript.all/Camera.as: expect
                  a failure on availability of Camera class for
                  old version (will likely change again in the future
                  if we confirm that availability of classes doesn't
                  depend on SWF version).

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.2083&r2=1.2084
http://cvs.savannah.gnu.org/viewcvs/gnash/server/asobj/Global.cpp?cvsroot=gnash&r1=1.29&r2=1.30
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/actionscript.all/Camera.as?cvsroot=gnash&r1=1.9&r2=1.10

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.2083
retrieving revision 1.2084
diff -u -b -r1.2083 -r1.2084
--- ChangeLog   11 Jan 2007 12:47:26 -0000      1.2083
+++ ChangeLog   11 Jan 2007 13:29:32 -0000      1.2084
@@ -1,5 +1,17 @@
 2007-01-11 Sandro Santilli <address@hidden>
 
+       * server/asobj/Global.cpp: always provide the Function
+         and System classes. Add a note about possibly bogus
+         approach of making classes available based on SWF
+         version.
+       * testsuite/actionscript.all/Camera.as: expect
+         a failure on availability of Camera class for
+         old version (will likely change again in the future
+         if we confirm that availability of classes doesn't
+         depend on SWF version).
+
+2007-01-11 Sandro Santilli <address@hidden>
+
        * server/asobj/Stage.cpp: Stage is not a class, but
          just an object!
        * testsuite/actionscript.all/Stage.as: fix taking

Index: server/asobj/Global.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/asobj/Global.cpp,v
retrieving revision 1.29
retrieving revision 1.30
diff -u -b -r1.29 -r1.30
--- server/asobj/Global.cpp     11 Jan 2007 11:26:50 -0000      1.29
+++ server/asobj/Global.cpp     11 Jan 2007 13:29:32 -0000      1.30
@@ -18,7 +18,7 @@
 
 // Implementation of the Global ActionScript Object
 
-/* $Id: Global.cpp,v 1.29 2007/01/11 11:26:50 strk Exp $ */
+/* $Id: Global.cpp,v 1.30 2007/01/11 13:29:32 strk Exp $ */
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"
@@ -406,6 +406,15 @@
 
        //-------------------------------------------------
        // Unclassified - TODO: move to appropriate section
+       //
+       // WARNING: this approach seems to be bogus, in 
+       //          that the proprietary player seems to 
+       //          always provide all the core classes it
+       //          supports, reguardless of target SWF version.
+       //          The only difference seems to be in actual
+       //          usability of them. For example some will
+       //          be available [ typeof(Name) == 'function' ]
+       //          but not instanciatable.
        //-------------------------------------------------
 
        // ASSetPropFlags
@@ -414,6 +423,12 @@
        // See: http://sephiroth.it/reference.php?id=717&cat=1
        textsnapshot_class_init(*this);
 
+       // System and Function were added in Player Version 6, but
+       // seem to be available even if SWF target version is
+       // inferior
+       system_class_init(*this); // System and System.capabilities
+       function_class_init(*this);
+
        if ( vm.getSWFVersion() < 3 ) goto extscan;
        //-----------------------
        // SWF3
@@ -468,7 +483,6 @@
 
        set_member("LocalConnection", as_value(localconnection_new));
        set_member("TextFormat", as_value(textformat_new));
-       system_class_init(*this); // System and System.capabilities
        key_class_init(*this); // Key
        video_class_init(*this); // Video
        camera_class_init(*this); // Camera
@@ -477,7 +491,6 @@
        sharedobject_class_init(*this);
        loadvars_class_init(*this);
        customactions_class_init(*this);
-       function_class_init(*this);
 
        if ( vm.getSWFVersion() < 7 ) goto extscan;
        //-----------------------

Index: testsuite/actionscript.all/Camera.as
===================================================================
RCS file: /sources/gnash/gnash/testsuite/actionscript.all/Camera.as,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -b -r1.9 -r1.10
--- testsuite/actionscript.all/Camera.as        10 Jan 2007 00:09:56 -0000      
1.9
+++ testsuite/actionscript.all/Camera.as        11 Jan 2007 13:29:32 -0000      
1.10
@@ -20,13 +20,13 @@
 // compile this test case with Ming makeswf, and then
 // execute it like this gnash -1 -r 0 -v out.swf
 
-rcsid="$Id: Camera.as,v 1.9 2007/01/10 00:09:56 strk Exp $";
+rcsid="$Id: Camera.as,v 1.10 2007/01/11 13:29:32 strk Exp $";
 
 #include "check.as"
 
 #if OUTPUT_VERSION < 6
 
-check_equals(Camera, undefined);
+xcheck_equals(typeof(Camera), 'function');
 
 #else // OUTPUT_VERSION >= 6